[asterisk-dev] [Code Review] 3374: testsuite: Verify that each of three users entering a conference enters muted when using the startmuted user profile option

Mark Michelson reviewboard at asterisk.org
Tue Mar 25 09:46:55 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3374/#review11367
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On March 24, 2014, 10:54 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3374/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 10:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23461
>     https://issues.asterisk.org/jira/browse/ASTERISK-23461
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This relies on the addition of a test event in the conf_update_user_mute function:
> 
> 	ast_test_suite_event_notify("CONF_MUTE_UPDATE",
> 		"Mode: %s\r\n"
> 		"Conference: %s\r\n"
> 		"Channel: %s",
> 		mute_effective ? "muted" : "unmuted",
> 		user->b_profile.name,
> 		ast_channel_name(user->chan));
> 
> The test is pretty simple.  Three users enter a conference one after another while using a user profile with the startmuted option set. When all of the users have entered, the test is shut down. If any of those users' channels didn't receive the CONF_MUTE_UPDATE event or if the Mode for that event isn't muted, the test is failed.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/confbridge/tests.yaml 4872 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_start_muted/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_start_muted/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_start_muted/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_start_muted/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_start_muted/configs/ast1/confbridge.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3374/diff/
> 
> 
> Testing
> -------
> 
> Ran the test, confirmed the events, set the expectations of some things to intentional failures to verify that it would fail if mismatches occur. 
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140325/1a30b79d/attachment.html>


More information about the asterisk-dev mailing list