[asterisk-dev] [Code Review] 3357: testsuite: Add off-nominal subscription tests for PJSIP.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3357/#review11358
-----------------------------------------------------------


Four of the five tests presented here (no_event_header, below_min_expiry, unallowed, and unknown_event_package) should use the SIPp test case instead of copying and pasting the same run-test script for each one. This requires adding ~10 lines of yaml to test-config.yaml for each test and allows for run-test to be completely deleted for those tests. It's a good tradeoff. The no_accept_header could also be mostly yaml-driven, but the use of a run-test isn't quite as offensive there.

I think a no_accept_header test should be written for all event packages we support. For now that just means writing one for MWI. I'll leave the decision as to whether that should be done now as part of this work or whether that should have its own issue created to Matt.


/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/no_accept_header/sipp/subscribe.xml
<https://reviewboard.asterisk.org/r/3357/#comment21006>

    You have some problematic XML in this line here. I suggest changing the backslash-escaped double-quotes to """ and the > in the regex to
    &
    g
    t
    ;
    
    Sorry, I couldn't put those characters together because reviewboard actually decodes the string into the the > symbol :)



/asterisk/trunk/tests/channels/pjsip/subscriptions/presence/tests.yaml
<https://reviewboard.asterisk.org/r/3357/#comment21007>

    unallowed and below_min_expiry don't have anything to do with presence in particular, so they shouldn't be in the presence subdirectory.


- Mark Michelson


On March 14, 2014, 7:13 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3357/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 7:13 p.m.)
> 
> 
> Review request for Asterisk Developers, Kevin Harwell and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23342
>     https://issues.asterisk.org/jira/browse/ASTERISK-23342
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> No Accept header
> This would set up the subscription, but use the default type for the event package being subscribed for
> 
> Disallowed subscriptions
> A SIP UA subscribes for a valid event package with Asterisk, but the endpoint doesn't allow subscriptions
> Asterisk responds with a 603
> 
> MinExpiry not met
> A SIP UA sends a subscription with an expiration time that is less than the configured minexpiry for the endpoint
> Asterisk responds with a 423
> 
> No Event Header
> A SIP UA sends a subscription but fails to provide an Event header
> Asterisk responds with a 489
> 
> Unknown Event Package
> A SIP UA sends a subscription for an unknown event package
> Asterisk responds with a 489
> 
> 
> Each of these tests is based on kharwell's Digium Presence test. As such, the No Accept Header test does require some digium phone specific stuff to be loaded in order to work.  For all the other tests though, the tests are fairly general and will just fail for the reasons you would expect.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/unknown_event_package/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/unknown_event_package/sipp/subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/unknown_event_package/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/unknown_event_package/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/unknown_event_package/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml 4836 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unallowed/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unallowed/sipp/subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unallowed/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unallowed/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unallowed/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/tests.yaml 4836 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/no_accept_header/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/no_accept_header/sipp/subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/no_accept_header/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/no_accept_header/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/no_accept_header/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/below_min_expiry/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/below_min_expiry/sipp/subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/below_min_expiry/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/below_min_expiry/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/below_min_expiry/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/no_event_header/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/no_event_header/sipp/subscribe.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/no_event_header/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/no_event_header/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/subscriptions/no_event_header/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3357/diff/
> 
> 
> Testing
> -------
> 
> Ran tests to determine that the sipp scenarios were received the expected responses for every scenario.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140324/5b833544/attachment.html>