[asterisk-dev] [Code Review] 3313: Testsuite: Convert YAML Configuration Into Call File and Execute

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3313/#review11306
-----------------------------------------------------------



./asterisk/trunk/lib/python/asterisk/pluggable_modules.py
<https://reviewboard.asterisk.org/r/3313/#comment20949>

    If 'ami_connect' is the only valid trigger, this should throw an error if it is something else. If "trigger" is a required attribute, its existance should be enforced instead of that entry being silently omitted.



./asterisk/trunk/lib/python/asterisk/pluggable_modules.py
<https://reviewboard.asterisk.org/r/3313/#comment20950>

    Continuing noisily is better than silently ignoring the problem, but this should probably blow up instead since failing to provide call file configuration parameters is a configuration error.


Other than these two nitpicks, this looks pretty good.

- opticron


On March 6, 2014, 2:37 p.m., Scott Emidy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3313/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 2:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23217
>     https://issues.asterisk.org/jira/browse/ASTERISK-23217
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test uses the Pluggable Module Framework in order to convert a YAML configuration into an executable Call File by putting it into the correct directory, which is the 'astspooldir' directory.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/pbx/tests.yaml 4726 
>   ./asterisk/trunk/tests/pbx/create_call_files/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/pbx/create_call_files/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/sample-yaml/callfiles-config.yaml.sample PRE-CREATION 
>   ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4726 
> 
> Diff: https://reviewboard.asterisk.org/r/3313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Emidy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140320/0580b069/attachment-0001.html>