[asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

[Joshua Colp]

> On March 18, 2014, 4:22 p.m., Matt Jordan wrote:
> > /team/group/media_formats-reviewed/main/format.c, lines 292-296
> > <https://reviewboard.asterisk.org/r/3319/diff/1/?file=55696#file55696line292>
> >
> >     Where is this getting used?

I think... only musiconhold presently.


> On March 18, 2014, 4:22 p.m., Matt Jordan wrote:
> > /team/group/media_formats-reviewed/include/asterisk/frame.h, lines 131-141
> > <https://reviewboard.asterisk.org/r/3319/diff/1/?file=55694#file55694line131>
> >
> >     This feels a bit odd. ast_frame_video is basically just the same as ast_format, just with an rtp_marker_bit - which doesn't feel like its uniquely a property of ast_frame_video.
> >     
> >     Should whether or not the rtp_marker_bit is set be a property of something else somewhere?

It's supposed to signal end of a complete video frame (since it may cross multiple packets). Renaming it should probably be done but I'm not sure where else I'd put it.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3319/#review11278
-----------------------------------------------------------


On March 8, 2014, 5:36 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3319/
> -----------------------------------------------------------
> 
> (Updated March 8, 2014, 5:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Through implementing things some additional functionality needed to be added/tweaked. This does so.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/main/format_cap.c 410188 
>   /team/group/media_formats-reviewed/main/format.c 410186 
>   /team/group/media_formats-reviewed/main/codec.c 410188 
>   /team/group/media_formats-reviewed/include/asterisk/frame.h 410188 
>   /team/group/media_formats-reviewed/include/asterisk/format_cap.h 410188 
>   /team/group/media_formats-reviewed/include/asterisk/format_cache.h 410189 
>   /team/group/media_formats-reviewed/include/asterisk/format.h 410186 
>   /team/group/media_formats-reviewed/include/asterisk/codec.h 410188 
>   /team/group/media_formats-reviewed/include/asterisk/callerid.h 409286 
> 
> Diff: https://reviewboard.asterisk.org/r/3319/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140319/c5bb6fbe/attachment.html>