[asterisk-dev] [Code Review] 3360: ARI: allow json content type with zero length body

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3360/#review11219
-----------------------------------------------------------



/branches/12/main/http.c
<https://reviewboard.asterisk.org/r/3360/#comment20850>

    Pedantic: Curly braces go on the line before it.
    
    That's true of the part of the code just prior to this point as well.



/branches/12/main/http.c
<https://reviewboard.asterisk.org/r/3360/#comment20852>

    I don't think you need to clear errno here. ast_http_get_contents already will check for the content length and not set errno if content_length is 0:
    
    		content_length = get_content_length(headers);
    		if (content_length <= 0) {
    			/* no content - not an error */
    			return NULL;
    		}


- Matt Jordan


On March 14, 2014, 2:44 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3360/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 2:44 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: SWP-6748
>     https://issues.asterisk.org/jira/browse/SWP-6748
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Sam found that a DELETE request would fail with 400 when given a Content-Type of json but zero content length.  This patch avoids setting errno in the case that there is no content.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/http.c 410554 
> 
> Diff: https://reviewboard.asterisk.org/r/3360/diff/
> 
> 
> Testing
> -------
> 
> Passed my testing and also confirmed by Sam to fix the original failure he saw.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140314/43e9cca6/attachment.html>