[asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

[Olle E. Johansson]

On 13 Mar 2014, at 21:42, Paul Belanger <paul.belanger at polybeacon.com> wrote:

> On Thu, Mar 13, 2014 at 4:15 PM, Dan Austin <Dan_Austin at phoenix.com> wrote:
>> Matt wrote:
>> 
>> Not including this change does not seem to buy us anything, save for some
>> semblance of architectural purity. While I would love for there to be only
>> one way to perform DNS resolution, that feels like a long term goal - and
>> sacrificing the practicality of delivering a feature that a large number of
>> Asterisk users have wanted for an extremely long time doesn't feel worth it
>> to me.
>> 
>> 
>> 
>> I am indifferent to PJSIP and have no intent to use it any time soon, so my
>> critic is not of
>> 
>> that channel driver.  In times not so long past if a developer offered a new
>> feature for one
>> 
>> of the second-class channels or apps they stood a good chance being told to
>> rewrite it to
>> 
>> be channel agnostic,  that it should (had to) be coded in such a way that
>> all channels would
>> 
>> benefit.  It is kind of amusing to see that turned around to not apply to
>> the new kid on the block.
>> 
> +1 with Dan.  Comments aside on DNS functionality (I have opinions but
> sitting this one out). Any functionality should be channel agnostic.
> I too am a little concern'd that statement seems to have changed.

Well, I am not. First Matt kept chocking me by questioning a lot of our old
rules that seemed carved in stone. But in the end, we have something that
will lead to a much better product - which is the important thing. At some point
we will have to ask ourselves as a project about all these old rules - are they
still meaningful? Matt has done a lot of good for the project and the product
by doing this.

In this case though, I think he's wrong ;-)

I do agree with you a bit. While it is important to remember and follow
the core architecture of asterisk and try to be channel-agnostic, we also
have to ask ourselves what is going to be important a few years from now.
Will and ISDN-inspired core take us there? 

/O