[asterisk-dev] [Code Review] 3331: Allows app_chanspy to whisper to a spyee's bridged peer (barge) even if the bridged party answers after initial spy invocation.

[Robert Moss]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3331/
-----------------------------------------------------------

(Updated March 13, 2014, 7:24 p.m.)


Review request for Asterisk Developers.


Changes
-------

Put duplicate code in a function.
Changed to negation test, removing 'magic number' 0
Removed unneeded assignment.


Bugs: ASTERISK-23381
    https://issues.asterisk.org/jira/browse/ASTERISK-23381


Repository: Asterisk


Description
-------

Chanspy now can whisper to the spyee's "bridged party" (callee) (aka barging) even if the Spy started before the bridged party answered.


Diffs (updated)
-----

  /trunk/apps/app_chanspy.c 410469 

Diff: https://reviewboard.asterisk.org/r/3331/diff/


Testing
-------

Chanspy on an extension while the spyee's call is still ringing, after the bridged party answers, both spied on parties can hear the monitor.


Thanks,

Robert Moss

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140313/a4145eab/attachment-0001.html>