[asterisk-dev] [Code Review] 3323: res_pjsip: Update PJSIP tests that evaluate ToS settings to go back to anticipating decimal values. Also fix another failure that is more recent.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3323/#review11163
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On March 10, 2014, 7:13 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3323/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 7:13 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and Scott Griepentrog.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> So in addition to ToS settings going back to using decimals for output after the patch at https://reviewboard.asterisk.org/r/3324/, one of the PJSIP tests was failing because the disallowed codecs field no longer appears in Sorcery objects.  This patch removes the check for the deny field... Just checking the allow field gets the complete picture as far as I can tell.
> 
> This change in behavior was caused by r410190
> pjsip: allow and disallow show same codecs
> 
> In order to prevent confusion over the allow and disallow
> list of codecs being the same an option for registering a
> field as an alias is added.  The alias field will be read
> from the configuration file, but afterwards is not listed
> as a known field.  With disallow set as an alias, the CLI
> command pjsip show endpoint # will list the allow= field,
> but not the disallow field.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/dialplan_functions/pjsip_endpoint/configs/ast1/extensions.conf 4809 
>   /asterisk/trunk/tests/channels/pjsip/ami/show_endpoint/test-config.yaml 4809 
> 
> Diff: https://reviewboard.asterisk.org/r/3323/diff/
> 
> 
> Testing
> -------
> 
> Ran tests against the patched version of Asterisk to check for success.  Success was achieved.  Without the patch applied, tests still failed. Without these changes to the testsuite, the tests failed in both versions. With just the changes to the disallow check, this would pass without the patch to change ToS values back to decimals.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140313/109d2cc1/attachment.html>