[asterisk-dev] [Code Review] 3336: ARI: Ensure ChannelEnteredBridge messages get to the managing application

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3336/#review11152
-----------------------------------------------------------

Ship it!


I think it just needs a comment; otherwise it looks good!


branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/3336/#comment20794>

    This probably deserves a comment as to why we're doing a subscribe here, but we also have other logic for subscribing to the bridge a channel is in.
    
    Actually, if this works, then we might be able to get rid of the other logic. This method is certainly a lot simpler.


- David Lee


On March 12, 2014, 8:33 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3336/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 8:33 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23295
>     https://issues.asterisk.org/jira/browse/ASTERISK-23295
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This fixes an issue where a Stasis application running over ARI and subscribed to ari/events could miss the ChannelEnteredBridge event because it did not subscribe to the new bridge fast enough.
> 
> To accomplish this, it subscribes the application controlling the channel to the new bridge before adding it to that bridge which required the stasis_app_control structure to maintain a reference to the stasis_app.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/stasis/control.c 410448 
>   branches/12/res/stasis/control.h 410448 
>   branches/12/res/res_stasis.c 410448 
> 
> Diff: https://reviewboard.asterisk.org/r/3336/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the ARI tests still functioned since I was unable to reproduce the bug this fixes.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140312/51c0a12b/attachment.html>