[asterisk-dev] [Code Review] 3277: testsuite: ARI Originate test for assigning UniqueId on channel creation

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3277/#review11112
-----------------------------------------------------------

Ship it!


These are all pedantic (and were commented to be fixed when the main code change went in)


/asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml
<https://reviewboard.asterisk.org/r/3277/#comment20776>

    And, 12.2.0



/asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml
<https://reviewboard.asterisk.org/r/3277/#comment20772>

    Which event are you referring to?



/asterisk/trunk/tests/rest_api/channels/originate_with_id/test-config.yaml
<https://reviewboard.asterisk.org/r/3277/#comment20774>

    12.2.0



/asterisk/trunk/tests/rest_api/channels/snoop_id/test-config.yaml
<https://reviewboard.asterisk.org/r/3277/#comment20773>

    12.2.0



/asterisk/trunk/tests/rest_api/playback/basic/test-config.yaml
<https://reviewboard.asterisk.org/r/3277/#comment20777>

    And here too


- Matt Jordan


On March 4, 2014, 11:21 a.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3277/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 11:21 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23120
>     https://issues.asterisk.org/jira/browse/ASTERISK-23120
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Tests included:
> 
> * rest_api/channels/originate_with_id: call origination with a specified Unique ID via ARI.
> 
> * rest_api/bridges/bridge_by_id: create bridge with Uniqueid ID and place channel in it.
> 
> * rest_api/playback/basic: play audio on channel and control it using unique id
> 
> * rest_api/channels/snoop_id: start and stop spy channel via unique id
> 
> Notes:
> 
> * originate tests borrow basic test plan and AMI/CEL checks from r3274 (AMI version of this same test).
> 
> * New class AriOriginateTestObject extends AriTestObject and overrides AMI channel origination with an ARI method.
> 
> * New configuration section 'requests' for WebSocketEventModule, which provides ability to issue post/delete/etc request in addition to or in place of a callback.
> 
> * Request uri's can now be constructed using variables from matched event, as in DELETE 'channel/{channel.id}'
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/tests.yaml 4735 
>   /asterisk/trunk/tests/rest_api/playback/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/playback/basic/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/playback/basic/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/tests.yaml 4735 
>   /asterisk/trunk/tests/rest_api/channels/snoop_id/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/snoop_id/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/originate_with_id/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/originate_with_id/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/tests.yaml 4735 
>   /asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/bridge_by_id/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/ari.py 4735 
> 
> Diff: https://reviewboard.asterisk.org/r/3277/diff/
> 
> 
> Testing
> -------
> 
> All tests passed against r3191.  Changing any specified id is detected by the test.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140306/b55cb898/attachment-0001.html>