[asterisk-dev] [Code Review] 3248: Fix for WebRTC over WSS not working

[Moises Silva]

> On March 4, 2014, 11:03 a.m., wdoekes wrote:
> > /branches/11/res/res_http_websocket.c, line 291
> > <https://reviewboard.asterisk.org/r/3248/diff/2/?file=55032#file55032line291>
> >
> >     Please trim the comment lengths a bit.
> >     
> >     72, 80 or 100 characters per line is more readable than the ~180 you have here.
> 
> Moises Silva wrote:
>     Fixed ... but, doesn't everybody has huge screens now days? ... I agree could be handy if I am reading code on my phone though :)
> 
> wdoekes wrote:
>     Thanks :)
>     
>     Some people use those screens for multiple windows at once.
>     
>     But even if they don't, humans tend to have less trouble reading
>     column layout than long lines. See also:
>     http://c2.com/cgi/wiki?ColumnModeSometimesBetterThanWidespan
>     
>     Another example: the github commit window fits just under 120 characters,
>     no matter what size of screen you have.

Cool thanks for the follow up with references, good arguments :)


- Moises


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3248/#review11041
-----------------------------------------------------------


On March 3, 2014, 1:19 a.m., Moises Silva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3248/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 1:19 a.m.)
> 
> 
> Review request for Asterisk Developers and rnewton.
> 
> 
> Bugs: ASTERISK-21930 and ASTERISK-23099
>     https://issues.asterisk.org/jira/browse/ASTERISK-21930
>     https://issues.asterisk.org/jira/browse/ASTERISK-23099
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Several fixes for the WebSockets implementation in res/res_http_websocket.c
> 
> * Flush the websocket session FILE* as fwrite() may not actually guarantee sending
>   the data to the network. If we do not flush, it seems that buffering on the SSL
>   socket for outbound messages causes issues
> 
> * Refactored ast_websocket_read to take into account that SSL file descriptors
>   may be ready to read via fread() but poll() will not actually say so because
>   the data was already read from the network buffers and is now in the libc buffers
> 
> This should fix an issue that I have experienced and other users may have reported [1][2][3], where
> secure websockets wouldn't work, messages seem to not make it into Asterisk
> 
> [1] http://lists.digium.com/pipermail/asterisk-users/2013-August/280175.html
> [2] https://issues.asterisk.org/jira/browse/ASTERISK-21930
> [3] https://issues.asterisk.org/jira/browse/ASTERISK-23099
> 
> 
> Diffs
> -----
> 
>   /branches/11/res/res_http_websocket.c 409360 
> 
> Diff: https://reviewboard.asterisk.org/r/3248/diff/
> 
> 
> Testing
> -------
> 
> See ASTERISK-21930 for details on other users testing these changes. I did both WS and WSS calls, confirmed audio works with chrome. This patch is for Asterisk 11 as the issue is reported on Asterisk 11, but I tested a few months ago and same issue existed on 12 and trunk. I created my own team branches for those too (/team/moy/webrtc-11, /team/moy/webrtc-12, /team/moy/webrtc-trunk)
> 
> Confirmed working by Sean Bright on Jan 20, 2014 on Asterisk 11 (see ASTERISK-21930 comment)
> 
> 
> Thanks,
> 
> Moises Silva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140305/95a2d6af/attachment.html>