[asterisk-dev] [Code Review] 3296: res_fax_spandsp: Resolve random segfaults in libspandsp when T.38 gateway is enabled

[Michal Rybarik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3296/
-----------------------------------------------------------

(Updated March 4, 2014, 10:29 p.m.)


Review request for Asterisk Developers.


Changes
-------

All issues resolved. Hopefully patch will be OK now.


Bugs: ASTERISK-20149
    https://issues.asterisk.org/jira/browse/ASTERISK-20149


Repository: Asterisk


Description
-------

T.38 gateway was producing random segfaults in libspandsp (during fax tone detection). Segfaults could happen when alaw/ulaw frames were passed to libspandsp code, because this code expect only slinear frames. Recoding of alaw/ulaw to slinear was added here.


Diffs (updated)
-----

  /branches/11/res/res_fax_spandsp.c 407152 

Diff: https://reviewboard.asterisk.org/r/3296/diff/


Testing
-------

Used in production on 3 hosts (2x SIP/DAHDI, 1x SIP/SIP), no segfault seen after applying patch (month ago). Before patch, there were segfaults every few days.


Thanks,

Michal Rybarik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140304/d5bee787/attachment-0001.html>