[asterisk-dev] [Code Review] 3294: Resolve issue in chan_sip.c when loading static realtime peer with qualify=yes

Matt Jordan reviewboard at asterisk.org
Mon Mar 3 21:32:37 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3294/#review11037
-----------------------------------------------------------

Ship it!


It probably wouldn't hurt to have another pair of eyes on this (it is chan_sip after all), but this looks like it won't introduce any problems.

- Matt Jordan


On March 3, 2014, 6:33 p.m., Trevor Peirce wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3294/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 6:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-17523
>     https://issues.asterisk.org/jira/browse/ASTERISK-17523
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When a static realtime peer with qualify=yes is loaded, Asterisk never sends a probe to determine if the peer is available.  This results in the peer being unable to receive calls from Asterisk because the status is permanently UNKNOWN.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 409434 
> 
> Diff: https://reviewboard.asterisk.org/r/3294/diff/
> 
> 
> Testing
> -------
> 
> Used in production with Asterisk 11.7.0 since release.
> 
> 
> Thanks,
> 
> Trevor Peirce
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140304/9449078d/attachment-0001.html>


More information about the asterisk-dev mailing list