[asterisk-dev] [Code Review] 3296: res_fax_spandsp: Resolve random segfaults in libspandsp when T.38 gateway is enabled

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3296/#review11036
-----------------------------------------------------------



/branches/11/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/3296/#comment20667>

    Red blob (extraneous trailing white space)
    
    



/branches/11/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/3296/#comment20668>

    Coding guidelines (https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines):
    
    2.6.2: Use { } even for single lines.
    
    2.6: Remove the extra spaces between parentheses.
    
    2.17.3: Use sizeof(*slndata), as opposed to the explicit type.



/branches/11/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/3296/#comment20669>

    Coding guidelines, extra spaces around parantheses



/branches/11/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/3296/#comment20670>

    I'd remove the ptr value here. It doesn't add much value, as you malloc it here and it isn't output elsewhere.



/branches/11/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/3296/#comment20673>

    Capitalization:
    
    "Unknown frame ..."
    
    You should also provide the frame format type for debugging:
    
    "Unknown frame format %d ...", f->subclass.format.id



/branches/11/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/3296/#comment20672>

    This should be demoted to a debug message.


- Matt Jordan


On March 3, 2014, 7:30 p.m., Michal Rybarik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3296/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 7:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-20149
>     https://issues.asterisk.org/jira/browse/ASTERISK-20149
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> T.38 gateway was producing random segfaults in libspandsp (during fax tone detection). Segfaults could happen when alaw/ulaw frames were passed to libspandsp code, because this code expect only slinear frames. Recoding of alaw/ulaw to slinear was added here.
> 
> 
> Diffs
> -----
> 
>   /branches/11/res/res_fax_spandsp.c 407152 
> 
> Diff: https://reviewboard.asterisk.org/r/3296/diff/
> 
> 
> Testing
> -------
> 
> Used in production on 3 hosts (2x SIP/DAHDI, 1x SIP/SIP), no segfault seen after applying patch (month ago). Before patch, there were segfaults every few days.
> 
> 
> Thanks,
> 
> Michal Rybarik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140304/977ffbf1/attachment.html>