[asterisk-dev] [Code Review] 3287: testsuite: improve yaml exception handling

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3287/#review11034
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/test_config.py
<https://reviewboard.asterisk.org/r/3287/#comment20665>

    Why not print the backtrace here as well?  I'm not sure what other exceptions can be thrown by _parse_config, but I suspect the name of the exception class would be little help in finding any problem.
    
    I do like that yaml.YAMLError is handled separate, that way the special prefix can be given to the exception print-out.


- Corey Farrell


On March 3, 2014, 5:30 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3287/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 5:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds improved 
> 
> Changes:
> 
> Exception occurred while parsing config: <class 'yaml.parser.ParserError'>
> 
> To:
> 
> YAML error: while parsing a block mapping
>   in "tests/rest_api/recording/basic/test-config.yaml", line 2, column 1
> expected <block end>, but found '<block sequence start>'
>   in "tests/rest_api/recording/basic/test-config.yaml", line 71, column 9
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/test_config.py 4765 
> 
> Diff: https://reviewboard.asterisk.org/r/3287/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140304/6a742e22/attachment.html>