[asterisk-dev] [Code Review] 3279: Iterate through logger.conf [general] section

[Matt Jordan]

> On March 3, 2014, 12:47 p.m., Paul Belanger wrote:
> > So, what is needed to get this into 1.8, 11 as it stands now?  I'll be trying to use the new config framework and see if I can get it going.

Improvements that do not fix bugs are generally not made in the existing release branches - particularly for LTS releases. 12 had a very different policy from the very beginning, which was communicated ad nauseum.

Sometimes, in extremely rare cases, improvements have been allowed in the existing release branches. Generally, this has occurred when there is little to no risk of it affecting existing systems.

This patch actually is a behavioural change. If someone had two identical configuration parameters in logger.conf, it changes the preference from the first parameter to the last. While that may be preferable, it does introduce the possibility of an existing system no longer working mid-stream in an LTS release.

Barring a very convincing argument about how this cannot impact an existing system, and how this improvement will generally make a large number of people's lives better, I don't think this should be a candidate for inclusion in those branches.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3279/#review11029
-----------------------------------------------------------


On Feb. 28, 2014, 10:34 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3279/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 10:34 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch allows you to override the [general] section of logger.conf, making it the same functionality as the [logfiles] sections.
> 
> 
> Diffs
> -----
> 
>   trunk/main/logger.c 409111 
>   trunk/CHANGES 409111 
> 
> Diff: https://reviewboard.asterisk.org/r/3279/diff/
> 
> 
> Testing
> -------
> 
> local development. Setup
> 
> [general]
> queue_log = no
> queue_log = yes
> 
> Queue logfiles were created.
> 
> 
> Thanks,
> 
> Paul Belanger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140303/52dd31d9/attachment-0001.html>