[asterisk-dev] [Code Review] 3265: media_formats: Move app_fax over

[Joshua Colp]

> On Feb. 27, 2014, 9:12 p.m., Kevin Harwell wrote:
> > /team/file/media_formats-impl/apps/app_fax.c, lines 466-476
> > <https://reviewboard.asterisk.org/r/3265/diff/1/?file=54512#file54512line466>
> >
> >     What happens if orginal_read/write_fmt(s) are NULL?  Still proceed with setting the format even though it won't be restored later?  Not a problem if it was slin before.

Hrm, functionally speaking this is identical to how it was before. For the larger question it should be fine, if something else needs a different format it'll just end up changing it. The con is that this may use a translation path and it could exist for longer than necessary.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3265/#review10987
-----------------------------------------------------------


On Feb. 25, 2014, 12:55 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3265/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 12:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves app_fax over to the new media formats API.
> 
> 
> Diffs
> -----
> 
>   /team/file/media_formats-impl/apps/app_fax.c 408263 
> 
> Diff: https://reviewboard.asterisk.org/r/3265/diff/
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140301/e8f3805f/attachment.html>