[asterisk-dev] [Code Review] 3690: CEL: Fix incorrect/missing extra field information

[opticron]

> On June 30, 2014, 6:38 p.m., Corey Farrell wrote:
> > branches/12/res/res_pjsip_session.c, lines 1808-1810
> > <https://reviewboard.asterisk.org/r/3690/diff/3/?file=61385#file61385line1808>
> >
> >     What about space for the NULL terminator?

The space for the null terminator is allocated in the structure.


> On June 30, 2014, 6:38 p.m., Corey Farrell wrote:
> > branches/12/include/asterisk/causes.h, line 164
> > <https://reviewboard.asterisk.org/r/3690/diff/3/?file=61382#file61382line164>
> >
> >     I'm not sure how I feel about this name, hangup_sip2cause was fine for the static function but now that we're making it public I think I would rather see something ast_cause_*.  Not really sure what though, feel free to ignore this comment, I just wanted to point out that the name doesn't follow the normal convention.

I'll think about a better name for this.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3690/#review12398
-----------------------------------------------------------


On June 30, 2014, 3:04 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3690/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 3:04 p.m.)
> 
> 
> Review request for Asterisk Developers and Corey Farrell.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This corrects two issues with the extra field information in Asterisk 12+ in channel event logs.
> 
> It is possible to inject custom values into the dialstatus provided by ast_channel_dial_type() Stasis messages that fall outside the enumeration allowed for the DIALSTATUS channel variable. CEL now filters for the allowed values and ignores other values.
> 
> The "hangupsource" extra field key is always blank if the far end channel is a chan_pjsip channel. This is because the hangupsource is never set for the pjsip channel driver. This change sets the hangupsource whenever a hangup is queued for chan_pjsip channels.
> 
> This corrects an issue with the pjsip channel driver where the hangupcause information was not being set properly. This required that the hangup_sip2cause functionality be pulled out of chan_sip and chan_pjsip into main/causes.c so that it could also be utilized by res_pjsip_session.
> 
> 
> Diffs
> -----
> 
>   branches/12/tests/test_cel.c 417545 
>   branches/12/res/res_pjsip_session.c 417545 
>   branches/12/main/cel.c 417545 
>   branches/12/main/causes.c PRE-CREATION 
>   branches/12/include/asterisk/causes.h 417545 
>   branches/12/channels/chan_sip.c 417545 
>   branches/12/channels/chan_pjsip.c 417545 
> 
> Diff: https://reviewboard.asterisk.org/r/3690/diff/
> 
> 
> Testing
> -------
> 
> Tested all three portions of the patch manually and the dial status portion using the included unit test.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140701/7d8b9c91/attachment.html>