[asterisk-dev] [Code Review] 3686: WebRTC: Add SHA-256 support to chan_pjsip and add option to make it answer using the offer media transport.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3686/#review12391
-----------------------------------------------------------



/branches/12/contrib/ast-db-manage/config/versions/51f8cb66540e_add_further_dtls_options.py
<https://reviewboard.asterisk.org/r/3686/#comment22600>

    Alas, these should actually be 'yes' or 'no' values. That means they should use an enum:
    
    YESNO_NAME = 'yesno_values'
    YESNO_VALUES = ['yes', 'no']
    
    op.add_column('ps_endpoints', sa.Column('force_avp', yesno_values))
    op.add_column('ps_endpoints', sa.Column('media_use_received_transport', yesno_values))
    
    Unfortunately, that also means that we have to check for the existence of the enum when upgrading:
    
        ############################# Enums ##############################
    
        # yesno_values have already been created, so use postgres enum object
        # type to get around "already created" issue - works okay with mysql
        yesno_values = ENUM(*YESNO_VALUES, name=YESNO_NAME, create_type=False)
    
    See the "add_pjsip_endpoint_options_for_12_1" file


- Matt Jordan


On June 30, 2014, 9:31 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3686/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 9:31 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change requires the work for 11 but the merge up is pretty much clean, so this review only includes the PJSIP parts.
> 
> SHA-256 support has been added as has two options. One option controls the outgoing transport in SDP offers and the other controls the transport in SDP answers.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_sdp_rtp.c 417661 
>   /branches/12/res/res_pjsip/pjsip_configuration.c 417661 
>   /branches/12/res/res_pjsip.c 417661 
>   /branches/12/include/asterisk/res_pjsip_session.h 417661 
>   /branches/12/include/asterisk/res_pjsip.h 417661 
>   /branches/12/contrib/ast-db-manage/config/versions/51f8cb66540e_add_further_dtls_options.py PRE-CREATION 
>   /branches/12/UPGRADE.txt 417661 
> 
> Diff: https://reviewboard.asterisk.org/r/3686/diff/
> 
> 
> Testing
> -------
> 
> Calling.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140630/2eddba2a/attachment.html>