[asterisk-dev] [Code Review] 3477: Japanese language patch for app_voicemail.c and say.c

[Kevin McCoy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3477/
-----------------------------------------------------------

(Updated June 29, 2014, 11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 417591


Bugs: ASTERISK-23324
    https://issues.asterisk.org/jira/browse/ASTERISK-23324


Repository: Asterisk


Description
-------

Created new review request with proper diffs. Japanese language support patch for sound files in app_voicemail.c and say.c, depends on entire sound file package currently available in release candidate format as per https://issues.asterisk.org/jira/browse/ASTERISK-23324
https://www.dropbox.com/s/axu6gfnf9fh40hz/asterisk-core-sounds-ja-wav-and-patch.tgz

Word order and plurals, dates, counts in Japanese are all significantly different than English, hence the need for this patch. Tested working with Asterisk 12.

Here is the installation procedure from the README contained in the RC archive:

----------


Install Asterisk Sound Files:
mkdir /var/lib/asterisk/sounds/ja 
cd /var/lib/asterisk/sounds/ja 
wget http://downloads.asterisk.org/pub/telephony/sounds/asterisk-core-sounds-ja-gsm-current.tar.gz 
tar xvfz asterisk-core-sounds-ja-gsm-current.tar.gz 
rm -f asterisk-core-sounds-ja-gsm-current.tar.gz 
chown -R asterisk.asterisk /var/lib/asterisk/sounds/ja

How To Change Default SIP Channel Language to Japanese

Using Asterisk (vanilla):
vi /etc/asterisk/sip.conf
Edit language variable to:
language = ja

Using FreePBX:
On the FreePBX menu -> Settings -> Asterisk SIP Settings -> Advanced General Settings section -> Language field 
Set Language field to : ja

Install Japanese Patch:
Download Asterisk 12 source
Change directory to Asterisk 12 source folder
Download the patches for say.c and app_voicemail.c
patch -p0 < say.c.20140226.jp.patch
patch -p0 < app_voicemail.c.20140226.jp.patch
Compile Asterisk 12 source as usual


------

I'm happy to answer questions about the code.


Diffs
-----

  /trunk/main/say.c 413007 
  /trunk/apps/app_voicemail.c 413007 

Diff: https://reviewboard.asterisk.org/r/3477/diff/


Testing
-------

Fixed code with diff r2 as requested. Please double check and give feedback.


Thanks,

Kevin McCoy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140630/2d7f5b87/attachment.html>