[asterisk-dev] [Code Review] 3658: SIP/SDP fmtp line may include whitespace between attributes

[Alexander Traud]

> On June 24, 2014, 7:58 p.m., opticron wrote:
> > /branches/11/channels/chan_sip.c, line 11201
> > <https://reviewboard.asterisk.org/r/3658/diff/1/?file=59977#file59977line11201>
> >
> >     It appears that this will need to be merged into 12/trunk when this patch goes in.

This patch was taken from 12/trunk, "backported" to 11 (in ampersands, because all I did, was to extract it from the original Opus/VP8 patch and tested it with my AMR code).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3658/#review12298
-----------------------------------------------------------


On June 20, 2014, 3:02 p.m., Alexander Traud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3658/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 3:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23916
>     https://issues.asterisk.org/jira/browse/ASTERISK-23916
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In SIP/SDP, the fmtp line is allowed to include whitespace between attributes. RFC 3267 chapter 8.3 (from 2001) includes an example for this. This was not removed in the updated RFC 4867 in 2007. Here, I propose to backport this one-line change into Asterisk 11 LTS.
> 
> This diff is based on (an excerpt of) SVN revision 397526, review 2723, and ASTERISK-21981. The change was tested with Nokia mobile phones, which allow more than one media attribute with the format AMR.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 416067 
> 
> Diff: https://reviewboard.asterisk.org/r/3658/diff/
> 
> 
> Testing
> -------
> 
> 11.10
> 
> 
> Thanks,
> 
> Alexander Traud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140628/9f7a9ac8/attachment.html>