[asterisk-dev] [Code Review] 3681: chan_dahdi: Provide AMI commands for controlling PRI debugging output (levels and file output)

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3681/#review12353
-----------------------------------------------------------

Ship it!


Minor nits.


/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22553>

    []'s are used to indicate optional items.
    <>'s are used to indicate user filled in items.
    
    For xml you need to use &lt &gt for <>.



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22554>

    same here


- rmudgett


On June 26, 2014, 2:50 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3681/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 2:50 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A series of AMI commands, these provide equivalents to the following CLI commands:
> 'pri set debug <level> span <span>' via PRISetDebug
> 'pri set debug file <output-file>'  via PRISetDebugFile
> 
> plus a bit of an odd one out with PRIUnsetDebugFile... doesn't really have a CLI equivalent, but it allows file logging for PRI to be disabled. This can also be accomplished by using 'pri set debug off span <span>', but I believe that's undesired behavior (because that should be dealing with per-span debugging and just completely ignores that other spans might be using file output) and have filed a bug report for it here: https://issues.asterisk.org/jira/browse/ASTERISK-23938
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 417163 
>   /trunk/CHANGES 417163 
> 
> Diff: https://reviewboard.asterisk.org/r/3681/diff/
> 
> 
> Testing
> -------
> 
> Used each AMI command with and without all parameters to make sure all error messages could be observed as expected and that the commands did what I expected them to do.
> Reviewed documentation for AMI commands within Asterisk
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140626/48930336/attachment.html>