[asterisk-dev] [Code Review] 3454: When Asterisk initiates an ICE-based session, then it must send it's STUN check messages using role "ICE-CONTROLLING". Currently it uses "ICE-CONTROLLED". Though the role conflict get's resolved correctly, it does not conform to http://tools.ietf.org/html/rfc5245#section-5.2

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3454/#review12352
-----------------------------------------------------------


I'm going to close out this review to https://reviewboard.asterisk.org/r/3679/, as it includes both the fix for FireFox along with the SHA-256 issue. This patch, while it fixed it locally, did not address the situation when Asterisk is the controller of the ICE negotiation. The patch on r3679 does.

- Matt Jordan


On April 16, 2014, 3:43 a.m., Marko Seidenglanz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3454/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 3:43 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23026
>     https://issues.asterisk.org/jira/browse/ASTERISK-23026
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The following patch must be applied to res_rtp_asterisk to make outgoing calls to WebRTC capable browsers working. This is necessary due to the following issue in role negotiation:
> https://code.google.com/p/webrtc/issues/detail?id=2717&can=4&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20Area%20Status%20Owner%20Summary
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/res/res_rtp_asterisk.c 412438 
> 
> Diff: https://reviewboard.asterisk.org/r/3454/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marko Seidenglanz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140626/30132df0/attachment.html>