[asterisk-dev] [Code Review] 3681: chan_dahdi: Provide AMI commands for controlling PRI debugging output (levels and file output)

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3681/#review12347
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/3681/#comment22542>

    Might I suggest the following names instead:
    PRIDebugSet
    PRIDebugFileSet
    PRIDebugFileUnset
    
    This way the related AMI commands will sort together.



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22549>

    "Which span to affect."



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22550>

    Path of file to write debug output.



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22543>

    Please put
    #if defined(HAVE_PRI)
    #endif /* defined(HAVE_PRI)
    around each of your new funcitons.  It is very tedious to study code that is not even included in your build.
    
    Also put underbars between words in the function name:
    action_pri_set_debug_file



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22545>

    curlies



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22547>

    span case



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22546>

    curlies



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3681/#comment22548>

    span case


- rmudgett


On June 26, 2014, 11:43 a.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3681/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 11:43 a.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A series of AMI commands, these provide equivalents to the following CLI commands:
> 'pri set debug <level> span <span>' via PRISetDebug
> 'pri set debug file <output-file>'  via PRISetDebugFile
> 
> plus a bit of an odd one out with PRIUnsetDebugFile... doesn't really have a CLI equivalent, but it allows file logging for PRI to be disabled. This can also be accomplished by using 'pri set debug off span <span>', but I believe that's undesired behavior (because that should be dealing with per-span debugging and just completely ignores that other spans might be using file output) and have filed a bug report for it here: https://issues.asterisk.org/jira/browse/ASTERISK-23938
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 417163 
>   /trunk/CHANGES 417163 
> 
> Diff: https://reviewboard.asterisk.org/r/3681/diff/
> 
> 
> Testing
> -------
> 
> Used each AMI command with and without all parameters to make sure all error messages could be observed as expected and that the commands did what I expected them to do.
> Reviewed documentation for AMI commands within Asterisk
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140626/c9b77328/attachment-0001.html>