[asterisk-dev] [Code Review] 3675: res_pjsip: Add ActionID to events created as a result of PJSIP Actions

Joshua Colp reviewboard at asterisk.org
Thu Jun 26 06:02:43 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3675/#review12334
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On June 26, 2014, 2:46 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3675/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 2:46 a.m.)
> 
> 
> Review request for Asterisk Developers and George Joseph.
> 
> 
> Bugs: ASTERISK-23947
>     https://issues.asterisk.org/jira/browse/ASTERISK-23947
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> A number of various PJSIP actions were failing to parse out and place the ActionID into their responses. Whoops.
> 
> This patch adds the ActionID to the events that are sent as a result of an action, including the eventlist finalization events.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_registrar.c 417246 
>   /branches/12/res/res_pjsip_pubsub.c 417246 
>   /branches/12/res/res_pjsip_outbound_registration.c 417246 
>   /branches/12/res/res_pjsip/pjsip_configuration.c 417246 
>   /branches/12/include/asterisk/res_pjsip.h 417246 
> 
> Diff: https://reviewboard.asterisk.org/r/3675/diff/
> 
> 
> Testing
> -------
> 
> Tests were updated in the Asterisk Test Suite to provide the ActionID and check for its presence. See r3676 for those tests.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140626/540a94c5/attachment.html>


More information about the asterisk-dev mailing list