[asterisk-dev] [Code Review] 3672: Bridging: Allow DTMF hook to pass execution to a different hook

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3672/
-----------------------------------------------------------

(Updated June 25, 2014, 6:55 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address Richard's and Mark's comments.


Repository: Asterisk


Description
-------

This change allows DTMF hooks to request that an alternative DTMF hook be executed. This behavior is triggered by a new return value for DTMF hooks while the hook to be executed is specified in the REINTERPRET_FEATURE channel variable.


Diffs (updated)
-----

  trunk/tests/test_channel_feature_hooks.c PRE-CREATION 
  trunk/main/bridge_channel.c 416731 
  trunk/include/asterisk/bridge_features.h 416731 

Diff: https://reviewboard.asterisk.org/r/3672/diff/


Testing
-------

Manual testing as well as the attached unittest. Note that the DTMF and interval tests have already been reviewed as part of https://reviewboard.asterisk.org/r/3649/ and that only the reinterpret DTMF test is new along with helper function reinterpret_callback().


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140625/039bdd8c/attachment-0001.html>