[asterisk-dev] app_queue: periodic-announce-frequency is not (always) respected for head-of-the-queue caller

[Stefano Lucetti]

----- Messaggio originale -----
> Da: "Matthew Jordan" <mjordan at digium.com>
> A: "Asterisk Developers Mailing List" <asterisk-dev at lists.digium.com>
> Inviato: Mercoledì, 25 giugno 2014 20:18:35
> Oggetto: Re: [asterisk-dev] app_queue: periodic-announce-frequency is not (always) respected for head-of-the-queue
> caller
> 
>> ...
>> I guess that to fix this, the say_periodic_announcement() should be invoked inside the wait_for_answer(), or in the ring_one() (checked at a fixed rate, just like for the wait_our_turn() function), but I don't know where and how..
>>
>> Is it something that could be fixed?
>>
> 
> Generally, this is not a bug.
> 
> Announcements, by default, are not played to the first listener in
> the
> queue. This is to prevent the situation where an agent picks up but -
> because the person in the queue is getting an announcement - neither
> party can talk to the other until the announcement is finished.
> 
> Because some people did feel that this was a bug, an option was added
> mid-stream in 1.8.23.0, 'announce-to-first-user', that changes this
> behaviour such that the first person in the queue does get
> announcements. The aforementioned behaviour is a possibility, however
> - so expectations should be set for your agents when this feature is
> enabled.
> 
> Matt
> 

Hi Matt,
 I see the point, and that makes sense.. However, in 1.8-cert (app_queue 
Rev. 376303), periodic announcements *are* actually played to first 
listener in the queue.. just with the wrong  timing, driven by timeouts ..

The say_periodic_announcement() was added in the wait_for_answer() in 
r386792, actually solving the timing issue rather than adding the feature 
(as far as I see).. 

There shouldn't be anything wrong in porting that commit to certified, I'll 
let you know the results..

Thank you
Stefano 

PS: As a side effect of r386792, it should also be safe to remove the call to 
say_periodic_announce() in queue_exec()..