[asterisk-dev] [Code Review] 3674: media_formats: remove ast_format_copy, directly use ao2_bump or ao2_replace

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3674/
-----------------------------------------------------------

Review request for Asterisk Developers, Joshua Colp and Matt Jordan.


Repository: Asterisk


Description
-------

Remove ast_format_copy, make use of ao2_bump directly.  Use ao2_replace where appropriate.


Diffs
-----

  /team/group/media_formats-reviewed-trunk/tests/test_core_format.c 417232 
  /team/group/media_formats-reviewed-trunk/res/res_speech.c 417232 
  /team/group/media_formats-reviewed-trunk/res/res_rtp_asterisk.c 417232 
  /team/group/media_formats-reviewed-trunk/res/res_musiconhold.c 417232 
  /team/group/media_formats-reviewed-trunk/res/res_fax.c 417232 
  /team/group/media_formats-reviewed-trunk/res/res_agi.c 417232 
  /team/group/media_formats-reviewed-trunk/res/res_adsi.c 417232 
  /team/group/media_formats-reviewed-trunk/main/translate.c 417232 
  /team/group/media_formats-reviewed-trunk/main/smoother.c 417232 
  /team/group/media_formats-reviewed-trunk/main/slinfactory.c 417232 
  /team/group/media_formats-reviewed-trunk/main/rtp_engine.c 417232 
  /team/group/media_formats-reviewed-trunk/main/indications.c 417232 
  /team/group/media_formats-reviewed-trunk/main/frame.c 417232 
  /team/group/media_formats-reviewed-trunk/main/file.c 417232 
  /team/group/media_formats-reviewed-trunk/main/channel.c 417232 
  /team/group/media_formats-reviewed-trunk/main/bridge_channel.c 417232 
  /team/group/media_formats-reviewed-trunk/main/audiohook.c 417232 
  /team/group/media_formats-reviewed-trunk/main/app.c 417232 
  /team/group/media_formats-reviewed-trunk/main/abstract_jb.c 417232 
  /team/group/media_formats-reviewed-trunk/include/asterisk/slin.h 417232 
  /team/group/media_formats-reviewed-trunk/include/asterisk/format.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_ulaw.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_speex.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_lpc10.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_ilbc.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_gsm.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_g726.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_g722.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_alaw.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/ex_adpcm.h 417232 
  /team/group/media_formats-reviewed-trunk/codecs/codec_dahdi.c 417232 
  /team/group/media_formats-reviewed-trunk/channels/chan_phone.c 417232 
  /team/group/media_formats-reviewed-trunk/channels/chan_oss.c 417232 
  /team/group/media_formats-reviewed-trunk/channels/chan_misdn.c 417232 
  /team/group/media_formats-reviewed-trunk/channels/chan_dahdi.c 417232 
  /team/group/media_formats-reviewed-trunk/channels/chan_alsa.c 417232 
  /team/group/media_formats-reviewed-trunk/bridges/bridge_softmix.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_waitforsilence.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_test.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_talkdetect.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_speech_utils.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_sms.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_record.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_nbscat.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_mp3.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_milliwatt.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_ices.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_festival.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_fax.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_dictate.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_dahdibarge.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_chanspy.c 417232 
  /team/group/media_formats-reviewed-trunk/apps/app_amd.c 417232 
  /team/group/media_formats-reviewed-trunk/addons/chan_ooh323.c 417232 
  /team/group/media_formats-reviewed-trunk/addons/chan_mobile.c 417232 

Diff: https://reviewboard.asterisk.org/r/3674/diff/


Testing
-------

Compile only.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140625/aa1ec2fb/attachment.html>