[asterisk-dev] [Code Review] 3665: media_formats: Core updates, plus format_cache/channel/and some other stuff

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3665/
-----------------------------------------------------------

(Updated June 22, 2014, 3:06 p.m.)


Review request for Asterisk Developers, Corey Farrell and Joshua Colp.


Changes
-------

Update: remove cached formats of CELT/SILK, tweak rtp_engine's usage of them


Repository: Asterisk


Description
-------

*** This is not a formal review request yet ***

This patch includes all of Corey's fine work on r3625, plus enough work in format_cache/channel/dsp to get Asterisk's core to compile.

If you disable just about everything in menuselect, Asterisk _should_ get off the ground safely and be shut down safely (at least, on my machine. On a single run. Don't poke the beast hard, it may bite.)


Diffs (updated)
-----

  /team/group/media_formats-reviewed/tests/test_format_cache.c 417004 
  /team/group/media_formats-reviewed/main/slinfactory.c 417004 
  /team/group/media_formats-reviewed/main/rtp_engine.c 417004 
  /team/group/media_formats-reviewed/main/frame.c 417004 
  /team/group/media_formats-reviewed/main/format_cap.c 417004 
  /team/group/media_formats-reviewed/main/format_cache.c 417004 
  /team/group/media_formats-reviewed/main/dsp.c 417004 
  /team/group/media_formats-reviewed/main/codec_builtin.c 417004 
  /team/group/media_formats-reviewed/main/codec.c 417004 
  /team/group/media_formats-reviewed/main/channel.c 417004 
  /team/group/media_formats-reviewed/main/asterisk.c 417004 
  /team/group/media_formats-reviewed/include/asterisk/format_cache.h 417004 
  /team/group/media_formats-reviewed/include/asterisk/channel.h 417004 

Diff: https://reviewboard.asterisk.org/r/3665/diff/


Testing
-------


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140622/60848de5/attachment-0001.html>