[asterisk-dev] [Code Review] 3661: Move eid functions to utils.c, mark netsock.h deprecated

Corey Farrell reviewboard at asterisk.org
Fri Jun 20 15:32:10 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3661/
-----------------------------------------------------------

(Updated June 20, 2014, 4:32 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address missing brackets from original code.  Done separate so revision 1 could be a direct move with no changes.


Bugs: ASTERISK-23920
    https://issues.asterisk.org/jira/browse/ASTERISK-23920


Repository: Asterisk


Description
-------

Move eid functions from netsock.c to utils.c.  These functions were already published by utils.h.  Flag netsock.h as deprecated and switch res_pjsip_session.h to use netsock2.h.  The only code that still uses netsock.h is chan_iax2.


Diffs (updated)
-----

  /trunk/main/utils.c 416846 
  /trunk/main/netsock.c 416846 
  /trunk/include/asterisk/res_pjsip_session.h 416846 
  /trunk/include/asterisk/netsock.h 416846 

Diff: https://reviewboard.asterisk.org/r/3661/diff/


Testing
-------

Compiled.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140620/12d485e1/attachment.html>


More information about the asterisk-dev mailing list