[asterisk-dev] [Code Review] 3622: documentation: features.conf.sample is unclear as to which parking options apply globally to all parking lots (11)

rmudgett reviewboard at asterisk.org
Thu Jun 19 18:47:57 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3622/#review12244
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On June 19, 2014, 2:30 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3622/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 2:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23667
>     https://issues.asterisk.org/jira/browse/ASTERISK-23667
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The features.conf sample can be a bit confusing about what parking options can be set only in the general context, or both in the general context (for the default parking lot) and in other parking lot contexts. A bug was filed due to confusion and a little googling will show lots of other confused users.
> 
> Despite some comments on the individual options, it still reads in a confusing way. In this patch I separate out those options with some headings in to attempt a better layout. I went ahead and modified other headings in the file, or added them to facilitate better visual scanning.
> 
> Change to 1.8: https://reviewboard.asterisk.org/r/3621/
> 
> 
> Diffs
> -----
> 
>   /branches/11/configs/features.conf.sample 416556 
> 
> Diff: https://reviewboard.asterisk.org/r/3622/diff/
> 
> 
> Testing
> -------
> 
> Sample file update, doesn't affect configuration. Only rearranged text, no addition or removal of options or contexts. So, no testing, other than looking at it!
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/1f10734d/attachment-0001.html>


More information about the asterisk-dev mailing list