[asterisk-dev] [Code Review] 3593: astobj2: Additional refactoring to push impl specific code down into the impls.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3593/#review12242
-----------------------------------------------------------



branches/12/main/astobj2_container.c
<https://reviewboard.asterisk.org/r/3593/#comment22333>

    This should have stayed the way it was because this is an internal object to ao2 or you can keep only the ao2_t_ref() line for better debugging.



branches/12/main/astobj2_container.c
<https://reviewboard.asterisk.org/r/3593/#comment22335>

    extra blank line



branches/12/main/astobj2_container.c
<https://reviewboard.asterisk.org/r/3593/#comment22334>

    extra blank lines



branches/12/tests/test_astobj2.c
<https://reviewboard.asterisk.org/r/3593/#comment22336>

    Reviewborad is being weird about displaying the indented #defines.  Also this isn't normally indented in the code.


- rmudgett


On June 19, 2014, 6:04 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3593/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 6:04 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Move some implementation specific code from astobj2_container.c into astobj2_hash.c and astobj2_rbtree.c.  This completely removes the need for astobj2_container to switch on RTTI and it no longer has any knowledge of the implementation details.  The RTTI itself is no longer needed but I don't want to remove it until weak reference containers are added in case I need it back again.  If not, I'll remove it then.
> 
> 
> Diffs
> -----
> 
>   branches/12/tests/test_astobj2.c 416802 
>   branches/12/main/astobj2_rbtree.c 416802 
>   branches/12/main/astobj2_private.h 416802 
>   branches/12/main/astobj2_hash.c 416802 
>   branches/12/main/astobj2_container_private.h 416802 
>   branches/12/main/astobj2_container.c 416802 
>   branches/12/build_tools/cflags.xml 416802 
> 
> Diff: https://reviewboard.asterisk.org/r/3593/diff/
> 
> 
> Testing
> -------
> 
> Ran all the test framework tests plus the "astobj2 test" test.
> Ran testsuite tests/channels/pjsip.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/a3bec63a/attachment.html>