[asterisk-dev] [Code Review] 3648: RLS: Resource list configuration

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3648/
-----------------------------------------------------------

(Updated June 19, 2014, 10:47 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Matt's latest review.


Bugs: ASTERISK-23866
    https://issues.asterisk.org/jira/browse/ASTERISK-23866


Repository: Asterisk


Description
-------

Use https://wiki.asterisk.org/wiki/display/AST/Resource+List+Configuration as a guide for how RLS configuration was devised. The code on this review does not stray from that design. Note that most edge cases are not addressed at configuration time, but rather when a subscription is attempted to be established. The only edge case handled in this review is duplicated list items in a resource list.

I also added an AMI PJSIPShowResourceLists command to list details of configured lists.


Diffs (updated)
-----

  /team/group/rls/res/res_pjsip_pubsub.c 416805 

Diff: https://reviewboard.asterisk.org/r/3648/diff/


Testing
-------

I created the following resource list in pjsip.conf

[mylist]
type=resource_list
event=message-summary
list_item=foo
list_item=bar,baz
list_item=foo
full_state=yes
notification_batch_interval=5000

I ensured that I saw a warning message about ignoring the duplicated "foo" list item. I then ran PJSIPShowResourceLists and got the following output:

Response: Success
EventList: start
Message: A listing of resource lists follows, presented as ResourceListDetail events

Event: ResourceListDetail
ObjectType: resource_list
ObjectName: mylist
Event: message-summary
ListItem: foo,bar,baz
NotificationBatchInterval: 5000
FullState: false

Event: ResourceListDetailComplete
EventList: Complete
ListItems: 1


All seems well to me.


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/d817e3e9/attachment.html>