[asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

[Matt Jordan]

> On June 19, 2014, 12:48 p.m., Mark Michelson wrote:
> > trunk/main/bridge_channel.c, line 2468
> > <https://reviewboard.asterisk.org/r/3649/diff/1/?file=59857#file59857line2468>
> >
> >     Is this cast required? Either way, it's one of the weirder-looking things I've come across :)
> 
> Matt Jordan wrote:
>     I'd wrap ast_bridge_features_destroy in a type compatible function instead of this goofy cast.
> 
> opticron wrote:
>     The callback requires a void func(void *) function signature while ast_bridge_features_destroy is void func(struct ast_bridge_features *), so the cast is necessary. I can wrap it if that is preferable.

I'd wrap it.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12204
-----------------------------------------------------------


On June 19, 2014, 10:36 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3649/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 10:36 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: AFS-78
>     https://issues.asterisk.org/jira/browse/AFS-78
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch allows the current owner of a channel to define various feature hooks to be made available once the channel has entered a bridge.
> 
> Currently, it is only possible to attach these hooks by calling ast_bridge_join or as_bridge_impart directly.
> 
> 
> Diffs
> -----
> 
>   trunk/main/bridge_channel.c 416438 
>   trunk/main/bridge.c 416438 
>   trunk/include/asterisk/bridge_features.h 416438 
>   trunk/include/asterisk/bridge_channel.h 416438 
> 
> Diff: https://reviewboard.asterisk.org/r/3649/diff/
> 
> 
> Testing
> -------
> 
> Ensured that DTMF hooks could be attached to the channel via this mechanism and that they became available and were executable once the channel entered a bridge via Dial().
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/ee0122c9/attachment.html>