[asterisk-dev] [Code Review] 3633: Change in SETUP ACK handling (checking PI) in revision 413765 breaks working environments. This patch tries to make the change optional by adding a config option.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3633/#review12193
-----------------------------------------------------------


Update:

* The sample config with the new option
* The UPGRADE.txt file documenting the new option



/branches/11/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/3633/#comment22250>

    I don't think this option has to have the conditional guards surrounding it. If HAVE_PRI_SETUP_ACK_INBAND is not supported, the option simply won't do anything.
    
    That helps make this code slightly more sane (as much as anyone can claim that chan_dahdi is sane)


- Matt Jordan


On June 19, 2014, 1:17 a.m., Pavel Troller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3633/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 1:17 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: /, ASTERISK-23897 and Asterisk
>     https://issues.asterisk.org/jira/browse//
>     https://issues.asterisk.org/jira/browse/ASTERISK-23897
>     https://issues.asterisk.org/jira/browse/Asterisk
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The change introduced in revision 413765 limits opening the media channel and sending the PROGRESS control frame only to cases, when the Progress Indication with value "Inband Info now available" is present in the SETUP ACK message. However, there are exchanges (like Ericsson/Aastra MD110 BC13 or Avaya Definity (revision unknown)), which don't send this PI in SETUP ACK, but they send regular dial tone. Now the dial tone (and any subsequent audio information until some progress indication is received from the PBX) cannot be heard. My proposed solution is to introduce a new config option. I've called it "alwayssendprogress" and it's a binary no/yes option. In the "no" status, it keeps the new behaviour in place. In the "yes" status, it restores the old one.
> A better naming is possible, any proposals are welcome.
> The supplied patch was tested on current V11 SVN and it seems to be working as expected.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/sig_pri.c 416250 
>   /branches/11/channels/sig_pri.h 416250 
>   /branches/11/channels/chan_dahdi.c 416250 
> 
> Diff: https://reviewboard.asterisk.org/r/3633/diff/
> 
> 
> Testing
> -------
> 
> Regularly using the patch on three systems with no visible problems.
> 
> 
> Thanks,
> 
> Pavel Troller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/a87df6a4/attachment-0001.html>