[asterisk-dev] [Code Review] 3646: Enable Forward Secrecy (PFS) in TLS

Matt Jordan reviewboard at asterisk.org
Thu Jun 19 08:56:12 CDT 2014



> On June 19, 2014, 8:51 a.m., Matt Jordan wrote:
> > Closing this one out in favour of https://reviewboard.asterisk.org/r/3647/

Bah. Just saw that this one was for trunk, while 3647 was for Asterisk 12.

(This is why filling out a description is sometimes helpful :-) )

Feel free re-open this if you'd like, but as this is an improvement, it really should be a candidate for trunk only. Comparing the patches, other than their relative location in the file, they appear to be identical - as such, a single review should be sufficient.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3646/#review12190
-----------------------------------------------------------


On June 19, 2014, 8:51 a.m., Alexander Traud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3646/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 8:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23905
>     https://issues.asterisk.org/jira/browse/ASTERISK-23905
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> see Bugs
> 
> 
> Diffs
> -----
> 
>   trunk/main/tcptls.c 416071 
> 
> Diff: https://reviewboard.asterisk.org/r/3646/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Traud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/58133f6f/attachment-0001.html>


More information about the asterisk-dev mailing list