[asterisk-dev] [Code Review] 3629: pbx_lua: Remove the problematic and unnecessary AST_MODFLAG_GLOBAL_SYMBOLS from pbx_lua.c

[Dennis Guse]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3629/#review12186
-----------------------------------------------------------

Ship it!


Thanks George your patch solves the issue.

Extension.lua is loaded as expected on startup.
Also combining extensions.conf and extensions.lua is working as expected on startup.

Patched 11.7.0 on Ubuntu 14.04.

- Dennis Guse


On June 18, 2014, 11:27 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3629/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 11:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23818
>     https://issues.asterisk.org/jira/browse/ASTERISK-23818
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> AST_MODFLAG_GLOBAL_SYMBOLS was causing the module to be incorrectly loaded before pbx_config.  pbx_config was therefore blowing away contexts that were created by pbx_lua.  With AST_MODFLAG_DEFAULT the load order is now correct and contexs are being properly merged.  AST_MODFLAG_GLOBAL_SYMBOLS was not needed anyway since no other modules needed its global symbols that early.
> 
> This patch needs to be merged all the way though trunk.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/pbx/pbx_lua.c 416661 
> 
> Diff: https://reviewboard.asterisk.org/r/3629/diff/
> 
> 
> Testing
> -------
> 
> Checked that contexts created by both pbx_config and pbx_lua were properly merged instead of pbx_config overwriting them.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140619/6ce93654/attachment-0001.html>