[asterisk-dev] [Code Review] 3619: Testsuite: Simple tests of PUSH() and UNSHIFT() function with variable inheritance.

[Mark Michelson]

> On June 13, 2014, 9:07 p.m., Corey Farrell wrote:
> > /asterisk/trunk/tests/funcs/func_push/test-config.yaml, lines 113-115
> > <https://reviewboard.asterisk.org/r/3619/diff/2/?file=59661#file59661line113>
> >
> >     I just tried:
> >        minversion: '1.8.0'
> >        minversion: '11.0.0'
> >        minversion: '12.0.0'
> >     
> >     And it refused to run against /branches/1.8 due to it not being 12.0.0.  I think just set minversion 1.8.29.0.  The fact that it will fail against 11.10.0 and 12.3.0 is correct - the failure is due to a bug in those versions, not a missing feature.
> 
> Corey Farrell wrote:
>     Actually I would go a step farther and make this minversion: '1.8.0'.  PUSH and UNSHIFT functions existed before 1.8.0 and were broken, so it would be correct for this test to fail on all previous versions, instead of being skipped.

Setting minversion: '1.8.0' seems incorrect since the bug exists in all current released versions of 1.8. I wrote 1.8.29.0 since that is the next version of 1.8 to be released and is slated to have the fix implemented.

If specifying multiple minversions like I have does not allow the test to run on the 1.8 branch, then I'll try to figure out what the appropriate way of doing this is.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3619/#review12151
-----------------------------------------------------------


On June 13, 2014, 9:01 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3619/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 9:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This tests the changes introduced by /r/3616. Prior to those changes, the two INHERIT variables would not have been populated correctly by the second call to PUSH or UNSHIFT.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/funcs/tests.yaml 5118 
>   /asterisk/trunk/tests/funcs/func_push/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/funcs/func_push/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3619/diff/
> 
> 
> Testing
> -------
> 
> The test passes.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140617/e81e5204/attachment.html>