[asterisk-dev] [Code Review] 681: Add new AGI command: PARK

Jonathan Rose reviewboard at asterisk.org
Tue Jun 17 10:46:27 CDT 2014



> On June 17, 2014, 10:44 a.m., Jonathan Rose wrote:
> > This review should probably be closed.  There is absolutely no what it is still relevant given the changes to call parking that went into 12.
> 
> Jonathan Rose wrote:
>     s/no what/no way/

That said, this should be much easier to do in 12 and could follow a very similar structure to the manager park command in res/parking/parking_manager.c


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/681/#review12165
-----------------------------------------------------------


On June 16, 2010, 5:43 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/681/
> -----------------------------------------------------------
> 
> (Updated June 16, 2010, 5:43 a.m.)
> 
> 
> Review request for Asterisk Developers and bklang.
> 
> 
> Bugs: 17046
>     https://issues.asterisk.org/jira/browse/17046
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> bklang has submitted this patch to the issue tracker, it is now flagged ready for review.
> ---
> I needed a way to programmatically park calls via AGI and return the parking slot to the script for further processing. Since the generic EXEC AGI command does not allow returning information, I created this patch which adds the PARK command to AGI. On success, the parking lot space is returned. The PARK command accepts the same arguments as the dialplan function PARK and in fact uses the same parsing code. 
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_agi.c 270257 
>   /trunk/main/features.c 270257 
>   /trunk/include/asterisk/features.h 270257 
>   /trunk/CHANGES 270257 
> 
> Diff: https://reviewboard.asterisk.org/r/681/diff/
> 
> 
> Testing
> -------
> 
> Reporter only.
> 
> 
> Thanks,
> 
> Paul Belanger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140617/5ad5a99e/attachment.html>


More information about the asterisk-dev mailing list