[asterisk-dev] [Code Review] 3619: Testsuite: Simple tests of PUSH() and UNSHIFT() function with variable inheritance.
Mark Michelson
reviewboard at asterisk.org
Fri Jun 13 15:56:50 CDT 2014
> On June 13, 2014, 7:35 p.m., Corey Farrell wrote:
> > /asterisk/trunk/tests/funcs/func_push/test-config.yaml, line 113
> > <https://reviewboard.asterisk.org/r/3619/diff/1/?file=59650#file59650line113>
> >
> > This should be run against 1.8/11.
Yeah, on further inspection, the version is even wrong for 12, since this test won't work with 12.0.0.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3619/#review12147
-----------------------------------------------------------
On June 13, 2014, 2:50 p.m., Mark Michelson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3619/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 2:50 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> This tests the changes introduced by /r/3616. Prior to those changes, the two INHERIT variables would not have been populated correctly by the second call to PUSH or UNSHIFT.
>
>
> Diffs
> -----
>
> /asterisk/trunk/tests/funcs/tests.yaml 5118
> /asterisk/trunk/tests/funcs/func_push/test-config.yaml PRE-CREATION
> /asterisk/trunk/tests/funcs/func_push/configs/ast1/extensions.conf PRE-CREATION
>
> Diff: https://reviewboard.asterisk.org/r/3619/diff/
>
>
> Testing
> -------
>
> The test passes.
>
>
> Thanks,
>
> Mark Michelson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140613/35d6b0b7/attachment-0001.html>
More information about the asterisk-dev
mailing list