[asterisk-dev] [Code Review] 3615: MoH: Don't restart stream on repeated start calls

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3615/
-----------------------------------------------------------

(Updated June 13, 2014, 8:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 416150


Repository: Asterisk


Description
-------

Currently, music on hold will stop and then start again from the beginning if ast_moh_start() is called multiple times. This can happen if a call is put on hold repeatedly (the channel receives multiple HOLD control frames) and can be triggered from ARI by starting MoH on a channel multiple times. This is fairly jarring/annoying to users.

This change prevents MoH from being restarted if the requested music class is the same as the one currently playing.


Diffs
-----

  branches/1.8/res/res_musiconhold.c 415812 

Diff: https://reviewboard.asterisk.org/r/3615/diff/


Testing
-------

Verified that multiple calls to ast_moh_start() no longer cause MoH to stop and restart.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140613/ceefed07/attachment.html>