[asterisk-dev] [Code Review] 3617: Fix for AMI and SIP TCP being unresponsive to sending ouput.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3617/#review12140
-----------------------------------------------------------



/branches/1.8/main/tcptls.c
<https://reviewboard.asterisk.org/r/3617/#comment22163>

    The !! is a little weird.
    
    I'm assuming this is just to guarantee that it is 1? If so, why exactly is this needed?


- Matt Jordan


On June 12, 2014, 10:48 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3617/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 10:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23673
>     https://issues.asterisk.org/jira/browse/ASTERISK-23673
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Oops.  I broke it.
> 
> Unable to login to AMI and get output so it looks like you didn't get connected.
> 
> SIP TCP connections are unable to send responses.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/tcptls.c 416055 
>   /branches/1.8/main/manager.c 416055 
>   /branches/1.8/main/http.c 416055 
>   /branches/1.8/include/asterisk/tcptls.h 416055 
>   /branches/1.8/channels/chan_sip.c 416055 
> 
> Diff: https://reviewboard.asterisk.org/r/3617/diff/
> 
> 
> Testing
> -------
> 
> With the patch, AMI is able to get connected and async events are able to go out.
> With the patch, HTTP is able to timeout connections that don't complete.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140613/a8c6a7e8/attachment.html>