[asterisk-dev] [Code Review] 3600: testsuite: SIPNotify + PJSIPNotify behavioral tests

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3600/
-----------------------------------------------------------

(Updated June 11, 2014, 6:04 p.m.)


Review request for Asterisk Developers, Matt Jordan and Mark Michelson.


Changes
-------

Adds a testcase for the particular type of test I'm doing here... basically a SIPP scenario and an AMI action.

This is made sensitive to timeouts and AMI command failures. The previous version wasn't.

I've converted all of the tests I've written over.  There is also a pjsip_qualify test that could be converted to use this, but I haven't done so yet since it's a little outside the scope.


Repository: testsuite


Description
-------

Tests for the following behavior in PJSIPNotify action:
*PJSIPNotify sends notify messages with specified custom headers
*PJSIPNotify does not override reserved headers
*PJSIPNotify sends notify message content in the order that it was specified in the manager action

Tests the following behavior in SIPNotify action:
*SIPNotify sends notify messages with specified custom headers
*SIPNotify sends notify message content in the order that it was specified in the manager action

SIPNotify does not prevent modification of reserved headers, so that is not tested for SIPNotify. Whether or not it should is another question.


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/pjsip/ami/tests.yaml 5094 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/reserved_headers/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/reserved_headers/sipp/options.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/reserved_headers/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/custom_headers/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/custom_headers/sipp/options.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/custom_headers/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/content/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/content/sipp/options.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/ami/pjsip_notify/content/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/tests.yaml 5094 
  /asterisk/trunk/tests/channels/SIP/ami/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/ami/sip_notify/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/ami/sip_notify/custom_headers/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/ami/sip_notify/custom_headers/sipp/options.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/ami/sip_notify/custom_headers/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/ami/sip_notify/content/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/ami/sip_notify/content/sipp/options.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/ami/sip_notify/content/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/sipp.py 5094 

Diff: https://reviewboard.asterisk.org/r/3600/diff/


Testing
-------

Ran tests, mangled the expectations to create failures for each test.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140611/8984d915/attachment.html>