[asterisk-dev] [Code Review] 3611: CLI: correct presence state display

rnewton reviewboard at asterisk.org
Wed Jun 11 15:06:24 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3611/#review12129
-----------------------------------------------------------

Ship it!


Looks like it works to me!

The presence state now looks accurate and reflects what I see in "presencestate list"


newtonr-laptop*CLI> core show hints

    -= Registered Asterisk Dial Plan Hints =-
6002 at from-internal  : PJSIP/6002,CustomPre  State:Idle            Presence:available       Watchers  1


--- Name: 'CustomPresence:Alice'
    --- State: 'available'
    --- Subtype: ''
    --- Message: ''
    --- Base64 Encoded: 'No'


Plus 'core show hint' has the new column.

newtonr-laptop*CLI> core show hint 6002 
6002 at from-internal  : PJSIP/6002,CustomPre  State:Idle            Presence:available       Watchers  1
1 hint matching extension 6002





- rnewton


On June 11, 2014, 6 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3611/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 6 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23858
>     https://issues.asterisk.org/jira/browse/ASTERISK-23858
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds the presence column to the core show hint X output, and changes the presence string conversion to use the correct function.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/pbx.c 415698 
> 
> Diff: https://reviewboard.asterisk.org/r/3611/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140611/3d03b8c2/attachment-0001.html>


More information about the asterisk-dev mailing list