[asterisk-dev] [Code Review] 3599: menuselect fails to read config when all resource modules are disabled

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3599/#review12128
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On June 9, 2014, 7:21 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3599/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 7:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23830
>     https://issues.asterisk.org/jira/browse/ASTERISK-23830
> 
> 
> Repository: Menuselect
> 
> 
> Description
> -------
> 
> menuselect reads config using a char buf[2048].  This is too small if all resource modules are disabled - causing the last modules listed to be re-enabled.  This change expands the buffer to 8192.
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect.c 1157 
> 
> Diff: https://reviewboard.asterisk.org/r/3599/diff/
> 
> 
> Testing
> -------
> 
> make menuselect, disabled all resource modules, saved and went back in to verify all resource modules were still disabled.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140611/01df8b59/attachment.html>