[asterisk-dev] [Code Review] 3591: application_name support in cdr_pgsql and res_config_pgsql

[doome]

> On June 8, 2014, 11:38 a.m., wdoekes wrote:
> > /trunk/cdr/cdr_pgsql.c, lines 199-200
> > <https://reviewboard.asterisk.org/r/3591/diff/2-3/?file=59329#file59329line199>
> >
> >     If you add an assertion here that:
> >     
> >     conn == NULL
> >     
> >     you will notice that memory leaks when module -reloading cdr_pgsql.
> >     
> >     It's not freed in config_module.

Would it solve this if I add:

if (conn) {
	PQfinish(conn);
	conn = NULL;
}

to pgsql_reconnect?


- doome


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3591/#review12096
-----------------------------------------------------------


On June 10, 2014, 7:24 a.m., doome wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3591/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 7:24 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23737
>     https://issues.asterisk.org/jira/browse/ASTERISK-23737
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> See https://issues.asterisk.org/jira/browse/ASTERISK-23737
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_config_pgsql.c 415300 
>   /trunk/configs/res_pgsql.conf.sample 415300 
>   /trunk/configs/cel_pgsql.conf.sample 415300 
>   /trunk/configs/cdr_pgsql.conf.sample 415300 
>   /trunk/cel/cel_pgsql.c 415300 
>   /trunk/cdr/cdr_pgsql.c 415300 
> 
> Diff: https://reviewboard.asterisk.org/r/3591/diff/
> 
> 
> Testing
> -------
> 
> Used asterisk with the config paramterer pgdbappname and dbappname in cdr_pgsql.conf and res_config_pgsql.conf respectively, enabled and disabled. Worked as expected.
> 
> 
> Thanks,
> 
> doome
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140610/d04ee131/attachment-0001.html>