[asterisk-dev] [Code Review] 3587: chan_pjsip: PJSIPNotify - strip content-length headers, add documentation.

Mark Michelson reviewboard at asterisk.org
Mon Jun 9 16:31:35 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3587/#review12100
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On June 6, 2014, 9:56 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3587/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 9:56 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There was some confusion on usage of the PJSIPNotify manager command... notably in how headers are added to the notify message. This patch adds documentation explaining how to add headers and also adds some of the argument vetting from the chan_sip variant (SIPNotify).
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_notify.c 415411 
>   /branches/12/main/message.c 415411 
> 
> Diff: https://reviewboard.asterisk.org/r/3587/diff/
> 
> 
> Testing
> -------
> 
> Send some notifies with in the documented manner.  Added Content + Content-type + Content-length variables to test how that worked.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140609/1c47aa3b/attachment.html>


More information about the asterisk-dev mailing list