[asterisk-dev] [Code Review] 3586: testsuite: Update PJSIP blind transfer tests for expected direct media re-INVITEs

Joshua Colp reviewboard at asterisk.org
Sun Jun 8 11:52:22 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3586/#review12097
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On June 5, 2014, 9:33 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3586/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 9:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch updates the direct media tests for the expected re-INVITEs that will occur under review 3585. This includes:
>  - For the party in the bridge with the transfer destination, a re-INVITE that redirects media back to Asterisk will occur nearly at the same time as a BYE request (the order from Asterisk will always be re-INVITE, then BYE). This handles this situation by caching the necessary values from the re-INVITE, handling the BYE, then sending the response to the re-INVITE.
>  - A previously commented out direct media re-INVITE was restored. It should never have been commented out.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml 5094 
>   /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml 5094 
>   /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml 5094 
>   /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/alice.xml 5094 
> 
> Diff: https://reviewboard.asterisk.org/r/3586/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140608/850346a4/attachment.html>


More information about the asterisk-dev mailing list