[asterisk-dev] [Code Review] 3594: autoservice exit on clean shutdown

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3594/#review12087
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On June 6, 2014, 4:22 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3594/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 4:22 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23827
>     https://issues.asterisk.org/jira/browse/ASTERISK-23827
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds cleanup for the thread in autoservice.c.  Since this cleanup should only happen on graceful shutdown I'm also backporting ast_register_cleanup to 1.8.
> 
> Note this diff shows a comment that ast_callid_threadassoc_change is for 11+.  This will simply be the call to that procedure in 11, and not included in the commit for 1.8.  The changes to main/asterisk.c and includes/asterisk/asterisk.h are for 1.8 only.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/autoservice.c 415335 
>   /branches/1.8/main/asterisk.c 415335 
>   /branches/1.8/include/asterisk.h 415335 
> 
> Diff: https://reviewboard.asterisk.org/r/3594/diff/
> 
> 
> Testing
> -------
> 
> Ran testsuite tests/feature_call_pickup with REF_DEBUG on branches/11, verified this change resolved the leaked callid.  Compile only test for 1.8.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140606/a7d66a93/attachment.html>