[asterisk-dev] [Code Review] 3595: app_queue: delayed state event can trigger leavewhenempty ringing too early

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3595/
-----------------------------------------------------------

(Updated June 6, 2014, 12:10 p.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Bugs: AST-1248
    https://issues.asterisk.org/jira/browse/AST-1248


Repository: Asterisk


Description
-------

In a world where a single agent is available and doesn't answer the first call, it is possible for the caller to then be kicked out of the queue incorrectly.  Due to an uncommon mix of other event messages in transit (such as CEL), the state change for the agent's extension from ringing back to available can arrive after app_queue has already decided to kick the user.  This change saves the day by adding a slight delay before kicking the caller out of the queue, but only under the situation where that single available agent is the one that was just called and did not answer.


Diffs
-----

  /branches/1.8/apps/app_queue.c 415336 

Diff: https://reviewboard.asterisk.org/r/3595/diff/


Testing
-------


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140606/a02883eb/attachment.html>